refactor(history): remove our mode when we handle history object from the history lib #1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvo
reviewed
Nov 14, 2016
| @@ -76,7 +70,7 @@ describe('InstantSearch', () => { | |||
| <div /> | |||
| </InstantSearch> | |||
| ); | |||
| }).toThrowError('You must provide a `onStateChange` prop alongside the `state`, `createURL` props on <InstantSearch>'); | |||
There was a problem hiding this comment.
Side note: I do like to always denote any API entries with backticks to ease reading anywhere :p
|
soo good :D |
mthuret
force-pushed
the
refactor/remove-history
branch
from
10f92ce
to
9a3685d
Compare
… the history lib BREAKING CHANGE: - if you need to synchronize URL then you should provide your own way to do so using our onStateChange/state props. See our guide on the subject for more information - onStateChange can now be used without having to store the IS state externally
mthuret
force-pushed
the
refactor/remove-history
branch
from
9a3685d
to
32f4909
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IS works with only two mode now: controlled or uncontrolled.
-> uncontrolled means that the state is handled by IS
-> controlled means that you need to handle the state on your side.
onStateChange can be now used individually.