Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Trigger CI checks on branch push, not only on PR creation #1143

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

pixelastic
Copy link
Collaborator

I'm updating the validate workflow to trigger on each push, not only when a PR is created.

This is how the config on CircleCI used to work and allow to check the status of the checks before actually creating a PR (thus avoiding noise as one can debug checks without creating a PR for that)

@pixelastic
Copy link
Collaborator Author

I'm also taking this PR as the opportunity to check/debug the publish workflow on master again

@pixelastic pixelastic merged commit 9d99aa3 into master Oct 20, 2023
3 checks passed
@pixelastic pixelastic deleted the actions/publish branch October 20, 2023 14:52
github-actions bot pushed a commit that referenced this pull request Oct 20, 2023
# [1.8.0](v1.7.15...v1.8.0) (2023-10-20)

### Bug Fixes

* **ci:** Trigger CI checks on branch push, not only on PR creation ([#1143](#1143)) ([9d99aa3](9d99aa3))

### Features

* **ci:** Automate Docker image publication when merging on master ([#1142](#1142)) ([f0208ba](f0208ba))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant