This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
fix: upgrade prop-types dependency to 15.6+ #3003
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We ran into an issue using
react-instantsearch-dom@latest
during local development with regard to theprop-types@15.5.10
package, which seems to cause the following runtime error:It looks like the
exact
function was not added untilprop-types@15.6.0
according to the CHANGELOG, but theSearchBox
component ofreact-instantsearch-dom
makes use ofPropTypes.exact
while remaining onprop-types@15.5.10
.This manifests as a runtime error during local development when using
react-instantsearch-dom
as seen above.Result
By upgrading the
prop-types
package to v15.6+ (opting forprop-types@latest
here), this error should no longer happen when we are trying to usereact-instantsearch-dom
during local development.