Skip to content
This repository has been archived by the owner on Jul 2, 2018. It is now read-only.

onSlide event? #7

Closed
sean-clayton opened this issue Dec 29, 2015 · 7 comments · Fixed by #8
Closed

onSlide event? #7

sean-clayton opened this issue Dec 29, 2015 · 7 comments · Fixed by #8

Comments

@sean-clayton
Copy link
Contributor

I recently discovered that rerendering onUpdate will make react behave poorly, because update is fired immediately onload. If using update for rendering something, update will trigger a rerender, which will trigger update, which triggers a rerender, and yadda yadda yadda.

on('slide'), on the other hand, does not fire on rerender—only on a slide event (obviously).

I'm willing to add this functionality to the slider if y'all are accepting pull requests :)

@redox
Copy link
Contributor

redox commented Dec 30, 2015

Released in 1.7.0. Thank you for your help @sean-clayton 💯

@elinake
Copy link

elinake commented Feb 6, 2017

How exactly this is supposed to work, because now the dragging doesn't update the slider movement before dragging stops, and that is obviously not wanted behavior?

@vvo
Copy link
Contributor

vvo commented Feb 6, 2017

Hi @elinake, can you open a new issue describing your problem in details? Since this is an old issue. Thanks

@vvo
Copy link
Contributor

vvo commented Feb 6, 2017

Also most probably you might want to check https://github.com/leongersen/noUiSlider directly.

@binjospookie
Copy link

@vvo according to @elinake I pass smth like:

onSlide={(data) => {console.log(data}}

And when I drag slider's hands I see console.log, but slider's hands don't move.

@vvo
Copy link
Contributor

vvo commented Jan 22, 2018

Hey can you open a new issue and demonstrate your problem in a repository, or even as a PR of this repository?

Thanks

@binjospookie
Copy link

binjospookie commented Jan 22, 2018

My problem was resolved. I can write smth like "How to resolve" if it necessary.

It's not about wrapper's code. It's like guide.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants