Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/187 add filelock to avoid create multiple same preview #188

Merged
merged 6 commits into from
Jul 16, 2020
Merged

Feature/187 add filelock to avoid create multiple same preview #188

merged 6 commits into from
Jul 16, 2020

Conversation

inkhey
Copy link
Contributor

@inkhey inkhey commented Jul 3, 2020 •
edited
Loading

related to #187

POC for FileLock.

This current does :

  • Refactor manager with previewContext to limit code duplication
  • Add filelock at manager level
  • set ffmpeg to overwrite mode
  • add filelock for libreoffice too
  • add support for isort 5.* (to fix ci)

@inkhey inkhey requested a review from raphj July 10, 2020 14:50
@inkhey inkhey force-pushed the feature/187__add_filelock_to_avoid_create_multiple_same_preview branch from bac8957 to c98f1e2 Compare July 13, 2020 13:38
@inkhey inkhey marked this pull request as ready for review July 15, 2020 11:17
@inkhey inkhey merged commit b219150 into develop Jul 16, 2020
@inkhey inkhey mentioned this pull request Jul 16, 2020
Closed
@inkhey inkhey deleted the feature/187__add_filelock_to_avoid_create_multiple_same_preview branch July 21, 2020 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphj raphj raphj approved these changes

Assignees

@raphj raphj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inkhey @raphj