Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ledger: move catchpoint staging into a storage package (5 of N) #4836

Merged
merged 3 commits into from
Nov 30, 2022

Conversation

icorderi
Copy link
Contributor

@icorderi icorderi commented Nov 28, 2022

Summary

Continue moving methods out of accountdb.go.
This PR particularly moves "catchpoint staging".

Previous parts of this refactor:

What remains to be moved out:

  • setup stuff
    • table/index creations
    • table deletions
    • migrations
  • iterators
    • orderedAccountsIter
    • catchpointPendingHashesIterator
  • deltas
    • accountsLoadOld and resourcesLoadOld have a couple queries that we might want to move out to avoid pulling all the deltas into store

Test Plan

Existing tests.

@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Merging #4836 (d292ce5) into master (a00e8a5) will decrease coverage by 0.14%.
The diff coverage is 20.60%.

@@            Coverage Diff             @@
##           master    #4836      +/-   ##
==========================================
- Coverage   53.54%   53.39%   -0.15%     
==========================================
  Files         422      422              
  Lines       53852    53858       +6     
==========================================
- Hits        28834    28758      -76     
- Misses      22697    22805     +108     
+ Partials     2321     2295      -26     
Impacted Files Coverage Δ
ledger/store/accountsV2.go 4.76% <0.00%> (+0.02%) ⬆️
ledger/store/catchpoint.go 0.00% <0.00%> (ø)
ledger/accountdb.go 69.23% <63.33%> (+0.71%) ⬆️
ledger/catchupaccessor.go 64.70% <64.70%> (+0.57%) ⬆️
network/wsPeer.go 68.97% <0.00%> (-0.72%) ⬇️
ledger/acctupdates.go 69.34% <0.00%> (-0.25%) ⬇️
network/wsNetwork.go 64.74% <0.00%> (-0.18%) ⬇️
data/transactions/verify/txn.go 73.61% <0.00%> (ø)
ledger/testing/randomAccounts.go 56.61% <0.00%> (ø)
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@icorderi icorderi force-pushed the refactor/accountdb-5 branch 2 times, most recently from d13ca24 to 78c5554 Compare November 29, 2022 17:10
@algorandskiy algorandskiy merged commit 7aa2f8c into algorand:master Nov 30, 2022
@algorandskiy algorandskiy changed the title refactor: accountdb.go into a store package (5 of N) ledger: move catchpoint staging into a storage package (5 of N) Nov 30, 2022
winder pushed a commit to winder/go-algorand that referenced this pull request Dec 2, 2022
algolucky pushed a commit to algolucky/go-algorand that referenced this pull request Dec 15, 2022
@icorderi icorderi deleted the refactor/accountdb-5 branch December 16, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants