Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ledger: add kvIter to storage package (11 of N) #4892

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

icorderi
Copy link
Contributor

Summary

Handles the last remaining queries left in ledger used in production code.
A few sql statements remain in specific tests.

Previous parts of this refactor:

What remains to be moved out:

  • misc queries left in ledger
    • acctdeltas_test.go
    • acctupdates_test.go
    • catchpointtracker.go
    • catchpointwriter.go
    • catchpointwriter_test.go

Test Plan

Existing tests.

@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Merging #4892 (37db992) into master (8cb6779) will decrease coverage by 0.04%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##           master    #4892      +/-   ##
==========================================
- Coverage   53.69%   53.64%   -0.05%     
==========================================
  Files         430      431       +1     
  Lines       53529    53536       +7     
==========================================
- Hits        28741    28722      -19     
- Misses      22560    22586      +26     
  Partials     2228     2228              
Impacted Files Coverage Δ
ledger/store/kvsIter.go 0.00% <0.00%> (ø)
ledger/catchpointtracker.go 58.49% <50.00%> (+0.15%) ⬆️
ledger/catchpointwriter.go 59.37% <100.00%> (-0.63%) ⬇️
ledger/blockqueue.go 85.63% <0.00%> (-2.88%) ⬇️
network/wsPeer.go 67.06% <0.00%> (-1.91%) ⬇️
catchup/service.go 69.08% <0.00%> (-1.45%) ⬇️
network/wsNetwork.go 64.92% <0.00%> (-0.27%) ⬇️
data/transactions/verify/txn.go 74.57% <0.00%> (+0.84%) ⬆️
ledger/roundlru.go 96.22% <0.00%> (+5.66%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@algorandskiy algorandskiy merged commit 4279fff into algorand:master Dec 16, 2022
@algorandskiy algorandskiy changed the title refactor: accountdb.go into a store package (11 of N) ledger: add kvIter to storage package (11 of N) Dec 16, 2022
@icorderi icorderi deleted the refactor/accountdb-11 branch December 16, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants