Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ledger: move blockdb tests into a storage package (8 of N) #4860

Merged
merged 1 commit into from Dec 7, 2022

Conversation

icorderi
Copy link
Contributor

@icorderi icorderi commented Dec 5, 2022

Summary

This PR moves a left over test file to blockdb.

Previous parts of this refactor:

What remains to be moved out:

  • setup stuff
    • table/index creations
    • table deletions
    • migrations
  • iterators
    • orderedAccountsIter
    • catchpointPendingHashesIterator
  • deltas
    • accountsLoadOld and resourcesLoadOld have a couple queries that we might want to move out to avoid pulling all the deltas into store

Test Plan

Existing tests.

@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Merging #4860 (00cf6be) into master (00cf6be) will not change coverage.
The diff coverage is n/a.

❗ Current head 00cf6be differs from pull request most recent head a8c98cc. Consider uploading reports for the commit a8c98cc to get more accurate results

@@           Coverage Diff           @@
##           master    #4860   +/-   ##
=======================================
  Coverage   53.20%   53.20%           
=======================================
  Files         426      426           
  Lines       53904    53904           
=======================================
  Hits        28680    28680           
  Misses      22973    22973           
  Partials     2251     2251           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@algorandskiy algorandskiy changed the title refactor: accountdb.go into a store package (8 of N) ledger: move blockdb tests into a storage package (8 of N) Dec 7, 2022
@algorandskiy algorandskiy merged commit 8515e46 into algorand:master Dec 7, 2022
@icorderi icorderi deleted the refactor/accountdb-8 branch December 16, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants