-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Algod: Simulation run with increased limits on logs #5247
Algod: Simulation run with increased limits on logs #5247
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5247 +/- ##
==========================================
+ Coverage 53.78% 53.79% +0.01%
==========================================
Files 450 450
Lines 56201 56218 +17
==========================================
+ Hits 30226 30245 +19
- Misses 23626 23631 +5
+ Partials 2349 2342 -7
... and 11 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
9584b03
to
375b22f
Compare
35ced2f
to
51f669c
Compare
015b71d
to
833237f
Compare
907d799
to
4a840e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, I only have pretty minor comments
04436a3
to
07a1725
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for addressing all my concerns!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"unlimited" usefulness
Summary
Introduction of simulation run without limit on logs, issue #5230
This PR should proceed after introduction of #5253, which allowed sending request with raw body together with query params, and following things need to be done:
log
opcode related limitations (maxLogSize = 1024
,maxLogCalls = 32
) are hardcoded in binary.We might want to move them as part of consensus param? Except for consensus param, I can't think of a better location to let these constant reside.These constraints stay as is.
localConfig.go
, which is per-node configuration.EvalParam
, swap in the 2 constraints for running these opcodes, and use tracer to override the constraints through local config for running simulation (conditioned that we are unlimiting log in endpoint call).Test Plan
Test in e2e-script and restClient_test.go