Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Demarcation of act Only Dependencies #2

Closed
Tracked by #1
tzaffi opened this issue Mar 25, 2022 · 1 comment
Closed
Tracked by #1

Better Demarcation of act Only Dependencies #2

tzaffi opened this issue Mar 25, 2022 · 1 comment

Comments

@tzaffi
Copy link
Contributor

tzaffi commented Mar 25, 2022

Quoting @michaeldiamant

... we ought to disambiguate steps needed for act.

In order to get act to pass, I sourced various dependencies that I believe are not needed for github.
Disambiguation here means creating 1 or more steps dedicated to act dependencies. Goal is to make it easier to maintain the build.
I think the following dependencies are act-specific though it requires a round of testing:
curl, nodejs, python3-pip
Docker install (e.g. docker-ce)
Setup docker-compose

My own thoughts:

  • as much as possible, have the git build.yml refer back to our Makefile
  • create make commands that have act as their suffix (e.g. make dependencies-act)
  • have two commands that look almost the same make install-for-github v. make install-for-act that only differ in one command that runs only locally
@tzaffi
Copy link
Contributor Author

tzaffi commented Jan 13, 2023

Resolving as this hasn't been much of an issue

@tzaffi tzaffi closed this as completed Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants