You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
... we ought to disambiguate steps needed for act.
In order to get act to pass, I sourced various dependencies that I believe are not needed for github.
Disambiguation here means creating 1 or more steps dedicated to act dependencies. Goal is to make it easier to maintain the build.
I think the following dependencies are act-specific though it requires a round of testing: curl, nodejs, python3-pip
Docker install (e.g. docker-ce)
Setup docker-compose
My own thoughts:
as much as possible, have the git build.yml refer back to our Makefile
create make commands that have act as their suffix (e.g. make dependencies-act)
have two commands that look almost the same make install-for-github v. make install-for-act that only differ in one command that runs only locally
The text was updated successfully, but these errors were encountered:
Quoting @michaeldiamant
My own thoughts:
build.yml
refer back to ourMakefile
make
commands that haveact
as their suffix (e.g.make dependencies-act
)make install-for-github
v.make install-for-act
that only differ in one command that runs only locallyThe text was updated successfully, but these errors were encountered: