Use HTTP request format arg to determine response type #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonpaulos
force-pushed
the
fix-http-client
branch
from
4bc11c1
to
c376af0
Compare
|
I rebased this PR on top of #535 to get tests to pass |
algochoi
reviewed
Mar 7, 2022
jasonpaulos
force-pushed
the
fix-http-client
branch
from
c376af0
to
52a947f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert the behavior change in #477 which caused our HTTP client to determine the type (i.e. JSON or not) of a response based on the response headers. In theory this is an ok thing to do, but some edge cases have been reported where the response headers have been incorrect or not present -- in any case, they are not the most reliable.
This PR reverts HTTP response handing to our old behavior, which is to use the
formatquery param to determine the response format for GET requests. POST and DELETE requests assume the response is always JSON (we don't have any endpoints that go against this assumption).Closes #526