Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boxes: Add support for Boxes #348

Merged
merged 35 commits into from Nov 2, 2022
Merged

Boxes: Add support for Boxes #348

merged 35 commits into from Nov 2, 2022

Conversation

algochoi
Copy link
Contributor

@algochoi algochoi commented Jun 15, 2022 •
edited by michaeldiamant

Adds SDK support for Boxes introduced in algorand/indexer#1168 and algorand/go-algorand#4149.

Zeph Grunschlag and others added 12 commits June 2, 2022 17:26
Make StateSchema.undictify() return an object
d8b805c
@tzaffi
Make StateSchema.undictify() return an object (#340)
31c50a9
Merge branch 'feature/box-storage' of github.com:algorand/py-algorand…
953e596 
…-sdk into feature/box-storage
Merge remote-tracking branch 'origin/develop' into feature/box-storage
06ddedf
@tzaffi
CHANGELOG item for StateSchema.undictify() (#343)
faa13be
@algochoi @barnjamin @tzaffi
Box support for Application calls and Atomic Transaction Composer (#338)
d056766 
* starting to add box support

* Add boxes to atc

* Format files with black

* Add boxes docstring

* Add boxes support for appl creation

* Update cucumber steps for appl txn encoding for boxes

* Formatting

* Point testing branch to box-reference (WIP)

* Sort imports on relevant files and format

* Add translation for foreign apps in box refs and some local unit tests

* Add some invalid cases for box translation

* Check for None when iterating box refs

* Add self app id references and tests

* Minor changes for box support

* Split boxref to separate file

* Change box name type to bytes

* Change docs references from box string to bytes

* Refactor cucumber steps

* Refactoring code and adding docstrings

* Add another comment

* Change test steps to encode box args like app args

* Add safety checks for box references

* Add some detailed errors and refactor

* Format unit test

* Fix foreign index error and revise undictify method

* Finish merging cucumber steps

* Formatting

* Fix box tests again

* Encoded as bytes unit test (#344)

* Unit test for encoding.py's `encode_as_bytes()`

* Accept AttributeError for foreign apps array if it is referencing its own app id

* Add unit test for empty foreign app array

* Change unit test to pass in None foreign array

* Change undictify method for boxes

* Formatting

* Change test branch

* Change type hints for atc boxes

* Check for int type for box reference id

* Change type ignore annotation

Co-authored-by: Ben Guidarelli <ben.guidarelli@gmail.com>
Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>
@algochoi
Merge branch 'develop' into feature/box-storage
bf89b22
@algochoi
Merge branch 'develop' into feature/box-storage
6083ec3
@algochoi
Format imports
7204e50
@algochoi
Sort imports
9d6e98c
@algochoi
Format import again...
0a30487
@algochoi
Add back tests that were lost during merge
0727844
@algochoi algochoi mentioned this pull request Jun 30, 2022
Merged
algochoi
algochoi commented Jun 30, 2022
View reviewed changes
run_integration.sh Outdated Show resolved Hide resolved
@algochoi @barnjamin @tzaffi
Add Algod endpoint for GetApplicationBoxByName (#346)
256dc72 
* starting to add box support

* Add boxes to atc

* Format files with black

* Add boxes docstring

* Add boxes support for appl creation

* Update cucumber steps for appl txn encoding for boxes

* Formatting

* Point testing branch to box-reference (WIP)

* Sort imports on relevant files and format

* Add translation for foreign apps in box refs and some local unit tests

* Add some invalid cases for box translation

* Check for None when iterating box refs

* Add self app id references and tests

* Minor changes for box support

* Split boxref to separate file

* Change box name type to bytes

* Change docs references from box string to bytes

* Refactor cucumber steps

* Refactoring code and adding docstrings

* Add another comment

* Change test steps to encode box args like app args

* Add safety checks for box references

* Add some detailed errors and refactor

* Format unit test

* Fix foreign index error and revise undictify method

* Finish merging cucumber steps

* Formatting

* Fix box tests again

* Encoded as bytes unit test (#344)

* Unit test for encoding.py's `encode_as_bytes()`

* Accept AttributeError for foreign apps array if it is referencing its own app id

* Add unit test for empty foreign app array

* Change unit test to pass in None foreign array

* Change undictify method for boxes

* Formatting

* Change test branch

* Change type hints for atc boxes

* Add algod endpoint for getting app box by name

* Add steps test for box application path

* Escape forward slashes in uri

* Formatting

* Finish merging

* Add box integration tests

* Formatting

* Add boxes integration test tag to makefile

* Change step prefix

* Revert step prefix

* Change algod request for box search and test

* Change makefile test

* Formatting

* Remove unused line

* Change wording around box encoding steps

* Try running feature branch tests

Co-authored-by: Ben Guidarelli <ben.guidarelli@gmail.com>
Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>
algochoi
algochoi commented Jul 5, 2022
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
algochoi
algochoi commented Jul 5, 2022
View reviewed changes
algosdk/v2client/algod.py Outdated Show resolved Hide resolved
algochoi and others added 7 commits July 15, 2022 13:51
@algochoi
Box Storage: Add GetApplicationBoxes API and cucumber steps (#359)
96f4a27 
* Add GetApplicationBoxes API and add steps

* Temporarily set to list-boxes branch in SDK testing

* Conform to new response format in boxes API

* Change test branch

* Add max params to boxes endpoint

* Fix paths for empty queries

* Change steps to check for query params in boxes request

* Formatting

* Reset test branch

* Remove redundant part in cucumber step

* Minor refactoring for set equality

* Revert "Minor refactoring for set equality"

This reverts commit 0a2b0d7.

* Check list length first, then do set comparison after

* Revert test branch

* Fix branch name
@algochoi
Merge branch 'develop' into feature/box-storage
d9c0dd9
@algochoi
Add back sourcemap import in other steps
34bc453
@algochoi
Merge develop into feature/box-storage (#372)
783514f 
* Merge develop into feature/boxes

* Change testing branch
@algochoi
Merge in files from develop
c83d813
@ahangsu @barnjamin
@algobarb @tzaffi @algochoi @michaeldiamant @shiqizng @algojack @algolucky
Enhancement: Merge develop to feature/box-storage (#379)
9ea8676 
* add check to desc so we dont output null if undefined (#368)

* Bumped version to v1.16.1

* Enhancement: Trim the indexer images and use the sandbox instead of custom dockers (#367)

Co-authored-by: algochoi <86622919+algochoi@users.noreply.github.com>
Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com>

* Bug-fix: Pass verbosity through to testing harness (#373)

* Enhancement: Add State Proof support (#370)

* add stateproof support

* Enhancement: Deprecating use of langspec  (#371)

* Bumped version to v1.17.0

* Update README.md

Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>

* Mergeback: Release v1.17.0b1 (#378)

* Bumped version
* Update README.md

* bumped version to v1.17.0

Co-authored-by: Ben Guidarelli <ben.guidarelli@gmail.com>
Co-authored-by: Barbara Poon <barbara.poon@algorand.com>
Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>
Co-authored-by: algochoi <86622919+algochoi@users.noreply.github.com>
Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com>
Co-authored-by: shiqizng <80276844+shiqizng@users.noreply.github.com>
Co-authored-by: Jack Smith <jack.smith@algorand.com>
Co-authored-by: Jack <87339414+algojack@users.noreply.github.com>
Co-authored-by: Lucky Baar <lucky.baar@algorand.com>
@ahangsu
Merge branch 'develop' into feature/box-storage
c0dd456
@ahangsu ahangsu changed the title [WIP] Box Storage Feature branch Enhancement: [WIP] Box Storage Feature branch Sep 2, 2022
algochoi and others added 2 commits September 6, 2022 15:24
@algochoi @ahangsu @tzaffi
Box support for Indexer endpoints (#366)
346aeb3 
* Add path tests for Indexer boxes

* Add next page param in indexer api

* Formatting

* Modify step to add next token in indexer boxes test

* Update algosdk/v2client/indexer.py

Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>

* Update .test-env

Co-authored-by: Hang Su <hang.su@algorand.com>
Co-authored-by: Hang Su <87964331+ahangsu@users.noreply.github.com>
Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com>
@ahangsu @algochoi
Enhancement: Boxes Indexer Integration test (#382)
ef8be90 
* add indexer impl in sdk

* merge step for indexer

* add indexer confirmed steps

* add indexer confirmed steps

* add indexer confirmed steps

* minor

* change to ms sleep

* per new step expectation

* unify with applications.boxes

* phrasing

* Update .test-env

* Update tests/steps/application_v2_steps.py

Co-authored-by: algochoi <86622919+algochoi@users.noreply.github.com>

* Update tests/steps/application_v2_steps.py

Co-authored-by: algochoi <86622919+algochoi@users.noreply.github.com>

* merge sleep steps

Co-authored-by: algochoi <86622919+algochoi@users.noreply.github.com>
ahangsu
ahangsu reviewed Sep 15, 2022
View reviewed changes
.test-env Outdated Show resolved Hide resolved
tzaffi
tzaffi reviewed Sep 20, 2022
View reviewed changes
algosdk/v2client/algod.py Outdated Show resolved Hide resolved
tzaffi
tzaffi reviewed Sep 20, 2022
View reviewed changes
Copy link
Contributor

@tzaffi tzaffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions, including more line items to the CHANGELOG.md

@ahangsu ahangsu changed the title Enhancement: [WIP] Box Storage Feature branch Enhancement: Box Storage Feature branch Sep 20, 2022
@ahangsu ahangsu marked this pull request as ready for review September 20, 2022 17:14
tzaffi
tzaffi approved these changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@tzaffi tzaffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as the only remaining discussion is around the CHANGELOG

ahangsu
ahangsu approved these changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@ahangsu ahangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my approval left for the part I didn't write, i.e. mostly outside tests

jasonpaulos
jasonpaulos reviewed Sep 24, 2022
View reviewed changes
algosdk/box_reference.py Outdated Show resolved Hide resolved
algosdk/v2client/algod.py Show resolved Hide resolved
@jasonpaulos jasonpaulos mentioned this pull request Sep 30, 2022
Merged
@michaeldiamant michaeldiamant changed the title Enhancement: Box Storage Feature branch Boxes: Add support for Boxes Oct 31, 2022
michaeldiamant and others added 2 commits October 31, 2022 16:42
@michaeldiamant
Merge pull request #393 from michaeldiamant/update_again
bc03ab2
@michaeldiamant @ahangsu
Revert SDK_TESTING_BRANCH to master
8e0ccd6 
Co-authored-by: Hang Su <87964331+ahangsu@users.noreply.github.com>
@michaeldiamant michaeldiamant merged commit acf32c4 into develop Nov 2, 2022
@michaeldiamant michaeldiamant deleted the feature/box-storage branch November 2, 2022 12:53
@michaeldiamant michaeldiamant mentioned this pull request Nov 2, 2022
Merged
@algolucky algolucky mentioned this pull request Nov 2, 2022
Merged
ahangsu pushed a commit that referenced this pull request Nov 28, 2022
@algochoi @ahangsu
Boxes: Add support for Boxes (#348)
042273c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahangsu ahangsu ahangsu approved these changes

@tzaffi tzaffi tzaffi approved these changes

@jasonpaulos jasonpaulos jasonpaulos approved these changes

Assignees
No one assigned
Labels
New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@algochoi @tzaffi @jasonpaulos @ahangsu @michaeldiamant