Implement users controller #9
Conversation
In this change I created a controller to handle the /users/{userId}
endpoint, where userId could be a numeric ID or a user name.
I changed the naming convention for parameters from snake_case (user_id)
to camelCase (userId) because our client is written in Javascript and it
uses camelCase.
For now our database is just a file with some users in JSON format.
This change is a needed to implement the "Has user X solved problem Y"
because for that we need users first.
|
|
||
| problemsController := problems.NewController(deps.ProblemsDataProvider) | ||
| r.HandleFunc("/v1/problems/sets", problemsController.SetIndex) | ||
| r.GET("/v1/problems/sets", problemsController.SetIndex) |
There was a problem hiding this comment.
Isn't it a bit Confused to mix GET and SET verbs here? I understand that SET has a different meaning here but is still confusing
There was a problem hiding this comment.
I agree, we should probably change SetIndex to something else, but I would do that in a future change as this was not added in this PR.
There was a problem hiding this comment.
Ok, lets keep this in mind for future changes.
| "os" | ||
| ) | ||
|
|
||
| var ErrNotFound = errors.New("User not found") |
There was a problem hiding this comment.
Could be a good idea to have constant Errors
There was a problem hiding this comment.
The language does not allow to have constants of pointers, and errors.New() returns a pointer.
There was a problem hiding this comment.
Thank you for the explanation.
| } | ||
|
|
||
| for _, user := range users { | ||
| if user.UserName == userName { |
There was a problem hiding this comment.
Could you please describe what is your criteria to use variable, varName or VarName I am noticing the threes styles in this line.
There was a problem hiding this comment.
Of course.
Variables: simple camelCase. In this snippet, user is a User, userName is a user name.
Fields (in structs): exported fields (visible from outside the package) start with an uppercase letter, otherwise it will be visible only within this package.
There was a problem hiding this comment.
Excellent, we can add this to README just to be clear about the naming convention.
There was a problem hiding this comment.
That would be a lot, that's part of the language and there's already a README for that: https://github.com/golang/go/wiki/CodeReviewComments.
We could add that link to the README though.
In this change I created a controller to handle the /users/{userId}
endpoint, where userId could be a numeric ID or a user name.
I changed the naming convention for parameters from snake_case (user_id)
to camelCase (userId) because our client is written in Javascript and it
uses camelCase.
For now our database is just a file with some users in JSON format.
This change is a needed to implement the "Has user X solved problem Y"
because for that we need users first.