Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: namespace logic #78

Merged
merged 1 commit into from
Apr 16, 2019
Merged

fix: namespace logic #78

merged 1 commit into from
Apr 16, 2019

Conversation

gxcsoccer
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Apr 15, 2019

Codecov Report

Merging #78 into master will increase coverage by 0.45%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
+ Coverage   91.81%   92.26%   +0.45%     
==========================================
  Files          35       35              
  Lines        1809     1811       +2     
==========================================
+ Hits         1661     1671      +10     
+ Misses        148      140       -8
Impacted Files Coverage Δ
lib/producer/mq_producer.js 95.31% <100%> (-0.04%) ⬇️
lib/client_config.js 100% <100%> (ø) ⬆️
lib/consumer/mq_push_consumer.js 94.01% <100%> (+0.26%) ⬆️
lib/mq_client_api.js 77.2% <0%> (+3.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac0a146...98e8620. Read the comment docs.

Copy link
Collaborator

@denghongcai denghongcai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gxcsoccer gxcsoccer merged commit cb385e3 into master Apr 16, 2019
@gxcsoccer gxcsoccer deleted the fix-namespace branch April 16, 2019 03:04
@gxcsoccer
Copy link
Contributor Author

3.6.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants