-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: promiseify #20
feat: promiseify #20
Conversation
@dead-horse, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fengmk2, @csbun and @fangk to be potential reviewers. |
#19 有问题,这个全部 promise 化了,这个合并后发 3.0.0,我会用 2.6.1 的代码再发布一次 2.7.1,deprecate 掉 2.7.0 |
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
=========================================
Coverage ? 98.91%
=========================================
Files ? 6
Lines ? 277
Branches ? 40
=========================================
Hits ? 274
Misses ? 3
Partials ? 0
Continue to review full report at Codecov.
|
�先合并发 3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
promisify可能会影响了prototype下继承链内的this
await db.beginTransactionScope(async (connection, ctx) => {
const { query, commit } = connection;
const ret = await query('select now() as currentTime;'); // <-- 这里会在底层实现里找不到this
console.log(ret);
await commit(); // <-- 这里会在底层实现里找不到this
return { success: true };
});
[skip ci] ## 1.0.0 (2024-01-30) ### ⚠ BREAKING CHANGES * In `Promise.all` case, Parallel beginTransactionScope will create isolated transactions. * drop Node.js < 16 support ### Features * add *beginTransactionScope(scope) ([0013a63](0013a63)) * add count(table, where) ([6286c46](6286c46)) * add get(), list(), insert(), update() ([9cae1cb](9cae1cb)) * add options.needFields, default is true ([18e0dea](18e0dea)) * add queryOne api ([ali-sdk#9](https://github.com/node-modules/myrds/issues/9)) ([19fc1bb](19fc1bb)) * add Transaction ([cfdcf26](cfdcf26)) * add unlock/lock tables ([ali-sdk#97](https://github.com/node-modules/myrds/issues/97)) ([4dc3452](4dc3452)) * add unlock/lock tables ([ali-sdk#97](https://github.com/node-modules/myrds/issues/97)) ([0a61be6](0a61be6)) * dynamic retrieval of database connection configuration ([ali-sdk#110](https://github.com/node-modules/myrds/issues/110)) ([f437efb](f437efb)) * export connection and query diagnostics_channel ([ali-sdk#111](https://github.com/node-modules/myrds/issues/111)) ([64aa75d](64aa75d)) * export sqlstring method ([ali-sdk#79](https://github.com/node-modules/myrds/issues/79)) ([2e99ab8](2e99ab8)) * impl with typescript ([ali-sdk#103](https://github.com/node-modules/myrds/issues/103)) ([1cf7814](1cf7814)) * promiseify ([ali-sdk#20](https://github.com/node-modules/myrds/issues/20)) ([e4aed30](e4aed30)) * stats 增加使用中的连接数 ([ali-sdk#115](https://github.com/node-modules/myrds/issues/115)) ([2b152a1](2b152a1)) * support custom query lifecricle ([ali-sdk#104](https://github.com/node-modules/myrds/issues/104)) ([5941c69](5941c69)) * support doomed transaction scope on test cases ([ali-sdk#58](https://github.com/node-modules/myrds/issues/58)) ([b227bc1](b227bc1)) * support end() ([b3eab93](b3eab93)) * support insert multi rows ([abb4804](abb4804)) * support mysql2 ([#1](#1)) ([eb9f391](eb9f391)) * support query(sql, object) ([ali-sdk#12](https://github.com/node-modules/myrds/issues/12)) ([a55e82f](a55e82f)) * support transaction on one request ctx ([#7](#7)) ([3bd4e44](3bd4e44)) * update multiple rows ([ali-sdk#55](https://github.com/node-modules/myrds/issues/55)) ([859d818](859d818)) * use AsyncLocalStorage to refactor transaction, to make it more safe ([ali-sdk#108](https://github.com/node-modules/myrds/issues/108)) ([ae327fa](ae327fa)) * where condition support NULL value ([ali-sdk#60](https://github.com/node-modules/myrds/issues/60)) ([0d4d4ab](0d4d4ab)) * wrap generator function to promise ([ali-sdk#19](https://github.com/node-modules/myrds/issues/19)) ([fe1b4a3](fe1b4a3)) ### Bug Fixes * `where` with empty object ([ali-sdk#15](https://github.com/node-modules/myrds/issues/15)) ([db0b90e](db0b90e)) * add default value now() of `gmt_modified` and `gmt_create` ([ali-sdk#56](https://github.com/node-modules/myrds/issues/56)) ([db6d596](db6d596)) * don't export protected methods ([ali-sdk#106](https://github.com/node-modules/myrds/issues/106)) ([b2757df](b2757df)) * don't redefined sqlstring.escape ([ali-sdk#39](https://github.com/node-modules/myrds/issues/39)) ([5ca4489](5ca4489)) * export pool getter from rds client ([ali-sdk#102](https://github.com/node-modules/myrds/issues/102)) ([4048807](4048807)) * handle concurrent transaction ([ali-sdk#85](https://github.com/node-modules/myrds/issues/85)) ([d983478](d983478)) * move sql to error stack ([#8](#8)) ([54349cd](54349cd)) * mysql type not found ([ali-sdk#109](https://github.com/node-modules/myrds/issues/109)) ([6a9bc45](6a9bc45)) * query parameters are not allowed to be included in where ([ali-sdk#67](https://github.com/node-modules/myrds/issues/67)) ([52147de](52147de)) * should export conn property ([ali-sdk#101](https://github.com/node-modules/myrds/issues/101)) ([37afa42](37afa42)) * support multi lifecricle hooks ([ali-sdk#105](https://github.com/node-modules/myrds/issues/105)) ([53b0a70](53b0a70)) * use master branch ([758877d](758877d))
No description provided.