[Torch] platform alibaba bazel configuration #210
Conversation
pytorch_blade/bazel_build.py
Outdated
| for fpath in [ext_so_fpath, ral_so_fpath, disc_bin_fpath]: | ||
| fpath = os.path.realpath(os.path.join(bazel_bin_dir, fpath)) | ||
| for fpath in open("bazel_target_cfg.txt"): | ||
| fpath = os.path.realpath(os.path.join(bazel_bin_dir, fpath.strip())) | ||
| fname = os.path.basename(fpath) | ||
| _symlink_force(fpath, os.path.join(extdir, fname)) |
There was a problem hiding this comment.
Better check if these libraries do exist using os.path.exists
| @@ -47,7 +47,7 @@ def __init__(self, *args, **kwargs): | |||
| ] | |||
| torch_major_version, torch_minor_version = self.torch_version.split(".")[:2] | |||
| self.extra_opts = [ | |||
| "--copt=-DPYTORCH_VERSION_STRING={}".format(self.torch_version), | |||
| "--copt=-DPYTORCH_VERSION_STRING=\\\"{}\\\"".format(self.torch_version), | |||
There was a problem hiding this comment.
We had to use \\\ to quote strings. We had run out of the problem before since we had never use it.
pytorch_blade/bazel_build.py
Outdated
|
|
||
| for fpath in [ext_so_fpath, ral_so_fpath, disc_bin_fpath]: | ||
| fpath = os.path.realpath(os.path.join(bazel_bin_dir, fpath)) | ||
| for fpath in open("bazel_target_cfg.txt"): |
There was a problem hiding this comment.
Do you want users to extend this configuration file? If not, maybe some const string instead of an additional text file is enough.
If we want users to do something on the configuration file, we also need a guide doc to tell them how to do that.
There was a problem hiding this comment.
As comments said, I added some comments here. It does want users to extend it, but those users are mainly ourselves. So I don't want to add it to documentation since it might not be ready for users. A user is recommended to use the default setting.
pytorch_blade/src/BUILD
Outdated
| if_tensorrt_enabled(["-DTORCH_BLADE_BUILD_TENSORRT"]) | ||
| if_tensorrt_enabled(["-DTORCH_BLADE_BUILD_TENSORRT"]) + | ||
| if_platform_alibaba( | ||
| ["-DTORCH_BLADE_COMMUNITY_VERSION=false"], |
There was a problem hiding this comment.
In general, version means a number? The bool value is confusing.
There was a problem hiding this comment.
Done, renaming to TORCH_BLADE_PLATFORM_ALIBABA
tanyokwok
force-pushed
the
features/platform_alibaba
branch
from
8aed50f
to
2198b82
Compare
This pull request adds platform alibaba bazel configuration:
bazel_target_cfg.txt, so one can add extra libraries to torch_blade wheel//bazel:platform_alibaba/workspace.bzl, which can be overridedcommon_utils/version.h