Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GIE/tests] Add pattern matching test cases for GIE #2822

Closed
longbinlai opened this issue Jun 6, 2023 · 0 comments
Closed

[GIE/tests] Add pattern matching test cases for GIE #2822

longbinlai opened this issue Jun 6, 2023 · 0 comments
Assignees
@longbinlai @lixueclaire
Labels
component:gie good first issue Good for newcomers

Comments

@longbinlai
Copy link
Collaborator

longbinlai commented Jun 6, 2023 •
edited
Loading

There currently lacks in pattern match test cases in GIE. It's thus welcome to add more pattern matching test cases.
It's easy to do so, simply prepare the match case and the expected result (by using Tinkerpop) in:
https://github.com/alibaba/GraphScope/blob/main/interactive_engine/compiler/src/main/java/com/alibaba/graphscope/gremlin/integration/suite/standard/IrGremlinQueryTest.java

You can run the test locally according to: https://graphscope.io/docs/latest/interactive_engine/dev_and_test
The case will also be verified in the ci workflow.
@longbinlai longbinlai self-assigned this Jun 6, 2023
@longbinlai longbinlai changed the title [GIE/docs] Add pattern matching test cases for GIE [GIE/tests] Add pattern matching test cases for GIE Jun 6, 2023
@lixueclaire lixueclaire self-assigned this Jun 6, 2023
@lixueclaire lixueclaire mentioned this issue Jun 7, 2023
Merged
lixueclaire added a commit that referenced this issue Jun 8, 2023
@lixueclaire
[GIE/tests] Add pattern matching test cases for GIE (#2831)
653823b 
Committed-by: 有理 from Dev container

<!--
Thanks for your contribution! please review
https://github.com/alibaba/GraphScope/blob/main/CONTRIBUTING.md before
opening an issue.
-->

## What do these changes do?

As title.

## Related issue number

issue #2822
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@longbinlai longbinlai

@lixueclaire lixueclaire

Labels
component:gie good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@longbinlai @lixueclaire