[GIE Compiler] Unify Gremlin Timeout Configurations #2953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirly121
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2953 +/- ##
=======================================
Coverage 42.37% 42.37%
=======================================
Files 99 99
Lines 10649 10649
=======================================
Hits 4512 4512
Misses 6137 6137 Continue to review full report in Codecov by Sentry.
|
|
Set as 2s, but timeout shows 1.79s. Should we ignore the 1.79s in the output? |
longbinlai
reviewed
Jun 30, 2023
| public QueryTimeoutConfig(long executionTimeoutMS) { | ||
| this.executionTimeoutMS = executionTimeoutMS; | ||
| this.channelTimeoutMS = (long) (executionTimeoutMS * (1 - GRADUAL_FACTOR)); | ||
| this.engineTimeoutMS = (long) (executionTimeoutMS * (1 - 2 * GRADUAL_FACTOR)); |
There was a problem hiding this comment.
Make the three time align. Should be fine.
longbinlai
reviewed
Jul 3, 2023
It seems fine with the gremlin nodejs client.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Unify gremlin timeout configurations. By this pr, the console will output like this if gremlin query execution timeout is set to 2000ms.
Timeout can be set by two ways:
query.execution.timeout.ms: 2000inconf/ir.compiler.propertiesg.with(ARGS_EVAL_TIMEOUT, 2000).V()org.with(Tokens.ARGS_EVAL_TIMEOUT, 2000).V(). if timeout value is of long type, suffix with 'L'Related issue number
Fixes #2854