Fix predicate #354
Merged
Fix predicate #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt_token should be left value in predicate
…oid potential cyclice dependencies while using the library in pegasus.
longbinlai
reviewed
May 26, 2021
| | Some(pb_type::value::Item::I32(_)) | ||
| | Some(pb_type::value::Item::I64(_)) | ||
| | Some(pb_type::value::Item::F64(_)) | ||
| | Some(pb_type::value::Item::Str(_)) => unimplemented!(), |
There was a problem hiding this comment.
These unimplemented stuff is not so hard to fix.
longbinlai
reviewed
May 26, 2021
| if let Some(right) = right { | ||
| Ok(contains_property(name.clone(), right)) | ||
| } else { | ||
| unimplemented!() |
There was a problem hiding this comment.
and these unimplemented ones.
longbinlai
reviewed
May 26, 2021
| unimplemented!() | ||
| } | ||
| } | ||
| None => unimplemented!(), |
There was a problem hiding this comment.
Should None case be handled?
longbinlai
reviewed
May 26, 2021
longbinlai
approved these changes
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Related issue number
Fixes #286