Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(analytical): fix bug that flash app can not run on string oid graph #3570

Merged
merged 3 commits into from
Feb 23, 2024

Conversation

acezen
Copy link
Collaborator

@acezen acezen commented Feb 22, 2024

What do these changes do?

Related issue number

Fixes

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5829153) 45.32% compared to head (bcc7f02) 43.03%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3570      +/-   ##
==========================================
- Coverage   45.32%   43.03%   -2.30%     
==========================================
  Files         176      179       +3     
  Lines       16191    18575    +2384     
==========================================
+ Hits         7338     7993     +655     
- Misses       8853    10582    +1729     
Files Coverage Δ
python/graphscope/tests/unittest/test_flash.py 100.00% <100.00%> (ø)

... and 81 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bd2acb...bcc7f02. Read the comment docs.

lixueclaire
lixueclaire previously approved these changes Feb 22, 2024
Copy link
Collaborator

@lixueclaire lixueclaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acezen acezen merged commit 79be316 into alibaba:main Feb 23, 2024
28 checks passed
@acezen acezen deleted the acezen/bug-fix-flash branch February 23, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants