Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interactive): fix the bug in missing metadata in PathExpand #3667

Merged
merged 11 commits into from
Mar 29, 2024

Conversation

BingqingLyu
Copy link
Collaborator

What do these changes do?

As titled.

Related issue number

Fixes #3666

@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.16%. Comparing base (b81e511) to head (758b11b).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3667   +/-   ##
=======================================
  Coverage   26.16%   26.16%           
=======================================
  Files         188      188           
  Lines       17250    17250           
=======================================
  Hits         4514     4514           
  Misses      12736    12736           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b81e511...758b11b. Read the comment docs.

zhanglei1949
zhanglei1949 previously approved these changes Mar 27, 2024
Copy link
Collaborator

@zhanglei1949 zhanglei1949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shirly121
shirly121 previously approved these changes Mar 28, 2024
@BingqingLyu BingqingLyu dismissed stale reviews from shirly121 and zhanglei1949 via fa4cc37 March 29, 2024 03:22
zhanglei1949
zhanglei1949 previously approved these changes Mar 29, 2024
Copy link
Collaborator

@zhanglei1949 zhanglei1949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirly121 shirly121 merged commit b2db3bd into alibaba:main Mar 29, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Metadata missing for PathExpand
4 participants