Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Verify codegen #3680

Draft
wants to merge 118 commits into
base: main
Choose a base branch
from

todo: fix ic1,10 correct

44cbe83
Select commit
Failed to load commit list.
Draft

[WIP] Verify codegen #3680

todo: fix ic1,10 correct
44cbe83
Select commit
Failed to load commit list.
codefactor.io / CodeFactor succeeded Apr 1, 2024 in 2s

7 issues fixed. 4 issues found.

Annotations

Check notice on line 1 in flex/interactive/examples/ldbc/build_plugin.sh

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

flex/interactive/examples/ldbc/build_plugin.sh#L1

Use $(...) notation instead of legacy backticks `...`. (SC2006)

Check notice on line 540 in interactive_engine/compiler/src/main/java/com/alibaba/graphscope/common/ir/runtime/proto/GraphRelToProtoConverter.java

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

interactive_engine/compiler/src/main/java/com/alibaba/graphscope/common/ir/runtime/proto/GraphRelToProtoConverter.java#L385-L540

Complex Method

Check warning on line 285 in interactive_engine/compiler/src/main/java/com/alibaba/graphscope/common/ir/runtime/proto/GraphRelToProtoConverter.java

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

interactive_engine/compiler/src/main/java/com/alibaba/graphscope/common/ir/runtime/proto/GraphRelToProtoConverter.java#L285

Resolve unexpected comment. (com.puppycrawl.tools.checkstyle.checks.TodoCommentCheck)

Check warning on line 6 in flex/interactive/examples/ldbc/build_plugin.sh

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

flex/interactive/examples/ldbc/build_plugin.sh#L6

This loop will only ever run once. Bad quoting or missing glob/expansion? (SC2043)