Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interactive): Introduce Statistics Interface Abstraction in MetaData #3843

Merged
merged 16 commits into from
May 30, 2024

Conversation

BingqingLyu
Copy link
Collaborator

@BingqingLyu BingqingLyu commented May 24, 2024

What do these changes do?

This pr includes:

  1. Introduce Statistics Abstraction in Metadata
  2. In GOpt, build GLogue from Metadata
  3. In Store, provide the statistics information in ExpStore

Related issue number

#3844

@BingqingLyu BingqingLyu changed the title fix(interactive): Introduce Statistics Interface Abstraction in meta data fix(interactive): Introduce Statistics Interface Abstraction in MetaData May 24, 2024
@BingqingLyu BingqingLyu marked this pull request as draft May 24, 2024 09:02
@BingqingLyu BingqingLyu changed the title fix(interactive): Introduce Statistics Interface Abstraction in MetaData [WIP] fix(interactive): Introduce Statistics Interface Abstraction in MetaData May 24, 2024
Committed-by: bingqing.lbq from Dev container
@BingqingLyu BingqingLyu changed the title [WIP] fix(interactive): Introduce Statistics Interface Abstraction in MetaData fix(interactive): Introduce Statistics Interface Abstraction in MetaData May 27, 2024
@BingqingLyu BingqingLyu marked this pull request as ready for review May 27, 2024 05:29
Committed-by: bingqing.lbq from Dev container
Committed-by: bingqing.lbq from Dev container
Copy link
Collaborator

@longbinlai longbinlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BingqingLyu BingqingLyu merged commit d3fa932 into alibaba:main May 30, 2024
28 of 29 checks passed
@BingqingLyu BingqingLyu deleted the gopt_statistics branch May 30, 2024 05:53
siyuan0322 pushed a commit that referenced this pull request Jun 14, 2024
Fixes #3843
---------
Co-authored-by: siyuan0322 <siyuanzhang.zsy@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants