-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(interactive): support multiple properties on edge #3962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liulx20
changed the title
feature(interactive): support multiple property on edge
feature(interactive): support multiple properties on edge
Jun 20, 2024
liulx20
changed the title
feature(interactive): support multiple properties on edge
feat(interactive): support multiple properties on edge
Jun 20, 2024
liulx20
force-pushed
the
multip
branch
3 times, most recently
from
June 20, 2024 08:22
e2f2dd7
to
ec03f24
Compare
liulx20
force-pushed
the
multip
branch
3 times, most recently
from
June 23, 2024 02:13
ac1729b
to
9484a81
Compare
liulx20
force-pushed
the
multip
branch
4 times, most recently
from
June 26, 2024 03:19
f63f61f
to
11a6731
Compare
liulx20
requested review from
luoxiaojian and
zhanglei1949
and removed request for
luoxiaojian
June 26, 2024 03:20
liulx20
requested review from
luoxiaojian and
zhanglei1949
and removed request for
zhanglei1949
June 26, 2024 03:20
luoxiaojian
approved these changes
Jun 26, 2024
zhanglei1949
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support multiple properties on edge, we introduce new type
Record
andRecordView
here.Record
is associated with a property array through a pointer.RecordView
consists of an offset and a pointer to aTable
.Then we specialized a new csr type
MutableCsr<RecordView>
as multi-properties edge storage.MutableCsr<RecordView>
contains aTable
through which we organize multi-properties. Whenget_data()
is called, aRecordView
Object will be returned, we can get properties with the RecordView, and when it is necessary to insert edges into the graph, we need to encapsulate the multi-attributes into aRecord
.