Modify log info about fetching metrics #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks for contributing! |
sczyh30
pushed a commit
that referenced
this pull request
Dec 25, 2018
- Receiving "No metrics" response won't cause error log - Improve log about fetching metrics (cherry picked from commit ef96b15)
Arlmls
pushed a commit
to Arlmls/Sentinel
that referenced
this pull request
Jan 8, 2019
- Receiving "No metrics" response won't cause error log - Improve log about fetching metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
See #215 for details.
Does this pull request fix one issue?
Fixes #215
Describe how you did it
Add a "No metrics" content judgment, modify the log level and message in the try-catch block, and add a method in the
MachineInfoclass to identify the application in the log message.Describe how to verify it
Run a client and dashboard and test for metrics and no metrics
Special notes for reviews
The
MetricFetcherfile is formatted, so some of attributes line numbers are changed.