Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overloaded handleBlockException method for customized annotation extension support #223

Merged
merged 1 commit into from
Nov 1, 2018
Merged

Add overloaded handleBlockException method for customized annotation extension support #223

merged 1 commit into from
Nov 1, 2018

Conversation

bitonly
Copy link
Contributor

@bitonly bitonly commented Nov 1, 2018

Describe what this PR does / why we need it

overload handleBlockException method for extension

Does this pull request fix one issue?

Fixes #221

Describe how you did it

overload handleBlockException and origin handleBlockException reuse it

Describe how to verify it

Special notes for reviews

@sczyh30 sczyh30 added the to-review To review label Nov 1, 2018
@sczyh30 sczyh30 changed the title overload handleBlockException Add overloaded handleBlockException method for customized annotation extension support Nov 1, 2018
Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit 8f85dc5 into alibaba:master Nov 1, 2018
@sczyh30 sczyh30 removed the to-review To review label Nov 1, 2018
@sczyh30
Copy link
Member

sczyh30 commented Nov 1, 2018

Thanks for contributing!

@sczyh30 sczyh30 added this to the 1.4.0 milestone Nov 30, 2018
sczyh30 pushed a commit that referenced this pull request Dec 25, 2018
Arlmls pushed a commit to Arlmls/Sentinel that referenced this pull request Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AbstractSentinelAspect method don't satisfy for extension
2 participants