Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue to upgrade curator-recipes and related API. #2963

Merged
merged 4 commits into from
Jan 11, 2023

Conversation

pandaapo
Copy link
Contributor

Describe what this PR does / why we need it

In curator-recipes 5.X, some classes had been outdated.

Does this pull request fix one issue?

Fixes #2928

Describe how you did it

Describe how to verify it

Special notes for reviews

@sczyh30
Copy link
Member

sczyh30 commented Nov 21, 2022

The test cases seem to fail. Could you please resolve it?

@pandaapo pandaapo marked this pull request as draft November 21, 2022 16:30
@sczyh30 sczyh30 added dependencies Pull requests that update a dependency file area/data-source Issues or PRs related to data-source extension labels Nov 22, 2022
@pandaapo pandaapo marked this pull request as ready for review November 22, 2022 03:06
@pandaapo
Copy link
Contributor Author

@sczyh30 Could you merge this PR?

Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit 0133139 into alibaba:master Jan 11, 2023
@sczyh30
Copy link
Member

sczyh30 commented Jan 11, 2023

Thanks for contributing!

@sczyh30 sczyh30 added the kind/enhancement Category issues or prs related to enhancement. label Jan 11, 2023
@sczyh30 sczyh30 added this to the v2.0.0 milestone Jan 11, 2023
LearningGp pushed a commit that referenced this pull request Dec 28, 2023
…-source (#2963)

* Fix issue to upgrade curator-recipes and related API.
* Resolve test failure: ClassNotFoundException of ZooKeeperAdmin.
* Remove unused property in pom.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/data-source Issues or PRs related to data-source extension dependencies Pull requests that update a dependency file kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
2 participants