Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE in LogSlot#entry for recording rule ID #2980

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Fix NPE in LogSlot#entry for recording rule ID #2980

merged 1 commit into from
Nov 30, 2022

Conversation

JosephZhang3
Copy link
Contributor

@JosephZhang3 JosephZhang3 commented Nov 29, 2022

Describe what this PR does / why we need it

Fix NPE in LogSlot#entry, it will make system rule config not take effect.

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

Related to #2853

@JosephZhang3
Copy link
Contributor Author

@sczyh30 Previous email address is invalid,I've made a new PR.

@sczyh30 sczyh30 changed the title Fix NPE in LogSlot#entry Fix NPE in LogSlot#entry for recording rule ID Nov 30, 2022
@sczyh30 sczyh30 added the kind/bug Category issues or prs related to bug. label Nov 30, 2022
Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit 0561959 into alibaba:master Nov 30, 2022
@sczyh30
Copy link
Member

sczyh30 commented Nov 30, 2022

Thanks for contributing!

@brucelwl
Copy link

brucelwl commented Apr 11, 2023

@sczyh30 @JosephZhang3

这个修复治标不治本, SystemBlockException 中根本就没有添加 Rule, id获取到的永远是null, 需求:#2851

@sczyh30
Copy link
Member

sczyh30 commented Jun 12, 2023

Refer #3148, #3143

@zhangbao283
Copy link

这个bug1.8.6还没修复吗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants