Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ClusterTransport and ClusterToken interface so that cluster client and cluster server can has the same action #444

Closed
wants to merge 7 commits into from

Conversation

all4you
Copy link
Contributor

@all4you all4you commented Jan 23, 2019

Describe what this PR does / why we need it

  • Extract a super interface com.alibaba.csp.sentinel.cluster.ClusterToken for:

    • {@link com.alibaba.csp.sentinel.cluster.client.ClusterTokenClient}
    • {@link com.alibaba.csp.sentinel.cluster.server.ClusterTokenServer}
  • Extract a super interface com.alibaba.csp.sentinel.cluster.ClusterTransport for:

    • {@link com.alibaba.csp.sentinel.cluster.ClusterTransportClient}
    • {@link com.alibaba.csp.sentinel.cluster.ClusterTransportServer}
  • NettyTransportServer should not implements the ClusterTokenServer because it is a TransportServer not a TokenServer.
    So it should implements a TransportServer which maybe like ClusterTransportServer
    just like the NettyTransportClient implements ClusterTransportClient

Does this pull request fix one issue?

  • Unified the ClusterTransportClient and ClusterTransportServer with a same super interface ClusterTransport
  • Unified the ClusterTokenClient and ClusterTokenServer with a same super interface ClusterToken

@sczyh30 sczyh30 added the to-review To review label Jan 23, 2019
@codecov-io
Copy link

codecov-io commented Jan 23, 2019

Codecov Report

Merging #444 into master will decrease coverage by 0.2%.
The diff coverage is 51%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #444      +/-   ##
============================================
- Coverage     37.77%   37.57%   -0.21%     
- Complexity      984     1104     +120     
============================================
  Files           235      259      +24     
  Lines          7409     8213     +804     
  Branches       1016     1120     +104     
============================================
+ Hits           2799     3086     +287     
- Misses         4251     4732     +481     
- Partials        359      395      +36
Impacted Files Coverage Δ Complexity Δ
...mmand/handler/FetchClusterClientConfigHandler.java 0% <ø> (ø) 0 <0> (?)
.../handler/ModifyClusterServerFlowConfigHandler.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...mand/handler/ModifyClusterClientConfigHandler.java 0% <ø> (ø) 0 <0> (?)
...mmand/handler/GetParamFlowRulesCommandHandler.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...d/handler/FetchClusterFlowRulesCommandHandler.java 0% <ø> (ø) 0 <0> (ø) ⬇️
.../command/handler/FetchTopParamsCommandHandler.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...sentinel/slots/block/flow/param/ParamFlowRule.java 53.7% <ø> (+1.85%) 18 <0> (+1) ⬆️
.../handler/ModifyClusterFlowRulesCommandHandler.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...mmand/handler/FetchClusterServerConfigHandler.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...dler/FetchClusterParamFlowRulesCommandHandler.java 0% <ø> (ø) 0 <0> (ø) ⬇️
... and 94 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0750923...0d10365. Read the comment docs.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sczyh30 sczyh30 closed this Aug 4, 2020
@sczyh30 sczyh30 added area/cluster-flow Issues or PRs related to cluster flow control and removed to-review To review labels Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cluster-flow Issues or PRs related to cluster flow control
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants