Optimized the compilation speed of the memory compiler #2736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hengyunabc
reviewed
Nov 22, 2023
|
|
||
| public class PackageInternalsFinder { | ||
| private final ClassLoader classLoader; | ||
| private static final String CLASS_FILE_EXTENSION = ".class"; | ||
|
|
||
| private static final Map<String, JarFileIndex> INDEXS = new HashMap<>(); |
There was a problem hiding this comment.
这里会出现线程安全问题， 我把它换成线程安全的map
hengyunabc
reviewed
Nov 22, 2023
|
|
||
| private List<JavaFileObject> processJar(String packageName, URL packageFolderURL) { | ||
| try { | ||
| String jarUri = packageFolderURL.toExternalForm().substring(0, packageFolderURL.toExternalForm().lastIndexOf("!/")); |
There was a problem hiding this comment.
这里好像有问题，因为完整的 spring boot fat jar 里的 url 是 两层结构的。但这里只取了一层的 url 为 map 的key。
比如应用打包有一个 aaa.jar ，然后另外也有一个同名的 aaa.jar 是另外的 classloader 加载的，这里就会冲突了。
There was a problem hiding this comment.
如果是两层jar的话， 他应该会有两个!/， 会从第二个jar结尾开始截取，类似于 aaa.jar!/Boot-Lib/aaa.jar!/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimized the compilation speed of the memory compiler