GH-154: Lazy & RescheduleLazy migrate to LazyBase #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
yanminhui
force-pushed
the
GH-154
branch
2 times, most recently
from
a9fcbc5
to
1815c81
Compare
yanminhui
force-pushed
the
GH-154
branch
2 times, most recently
from
dd6a65f
to
30e1ede
Compare
|
FIXME: testLazyPerf caused by #156 . |
This reverts commit 94b2f39.
ChuanqiXu9
reviewed
Sep 18, 2022
Comment on lines
+301
to
+304
| explicit LazyBase(Handle coro) : _coro(coro) {} | ||
| LazyBase(LazyBase&& other) : _coro(std::move(other._coro)) { | ||
| other._coro = nullptr; | ||
| } |
There was a problem hiding this comment.
构造函数做成 protected 的会比较好，LazyBase 不应该可以被直接构造
There was a problem hiding this comment.
LazyBase 定义在命名空间 detail 内部，用户不应使用。
若把构造函数放在 protected 里面，由于 protected 构造函数无法被继承，将导致派生类全部要重新声明一遍，再委派给 LazyBase。
There was a problem hiding this comment.
hmmm，detail namespace 算弱约束吧，不过我不算很纠结这个
RainMark
reviewed
Sep 18, 2022
|
另外你需要签署 CLA 协议我们才能合入你的代码 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Closes #154
LazyandRescheduleLazymigrate toLazyBase.What is changing
Example