Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for Clang 15 compatibility in Generator. #374

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

faker2048
Copy link
Contributor

@faker2048 faker2048 commented Mar 14, 2024

Why

Closes #372.

Changes:

  • Generator.h and GeneratorTest.cpp: If the user is using Clang-15, skip compiling GeneratorTest.cpp directly and add a compilation warning in Generator.h.
  • README.md and README_CN.md: Removing specific mentions of Clang-15 compiler flag workarounds.
  • coro/test/CMakeLists.txt: Removed conditional compilation flags related to Clang-15.

TEST

Executed ctest on:

  • Apple Clang 15
  • Linux Clang 15

@faker2048
Copy link
Contributor Author

有点奇怪,这个pr的修改不应该对 CI 用的 clang14 有任何影响

Copy link
Collaborator

@ChuanqiXu9 ChuanqiXu9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@ChuanqiXu9
Copy link
Collaborator

可能是代码的问题也可能是 ci 的问题,但应该和这个 patch 无关。

@ChuanqiXu9 ChuanqiXu9 merged commit c7929c6 into alibaba:main Mar 14, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: Extra Increment on Generator::iterator After Completion Causes Crash Using Clang15
2 participants