Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support HiveSource and HiveSink in FlinkProcessor #129

Merged
merged 1 commit into from
May 10, 2023
Merged

Support HiveSource and HiveSink in FlinkProcessor #129

merged 1 commit into from
May 10, 2023

Conversation

yunfengzhou-hub
Copy link
Collaborator

@yunfengzhou-hub yunfengzhou-hub commented May 8, 2023 •
edited
Loading

What is the purpose of the change

This pull request adds support for hive source and sink in FlinkProcessor. An e2e example that verifies the correctness of the changes can be found at https://github.com/yunfengzhou-hub/feathub-examples/tree/flink-read-write-hive/flink-read-write-hive.

Brief change log

  • Adds Hive source and sink in FlinkProcessor.
  • Support converting Feathub types to Flink SQL types.
  • Move notebook example verification process to nightly CI.
  • Rename parameter extra_config to processor_specific_props in MySQLSource and MySQLSink.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API: yes

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? docs

@yunfengzhou-hub yunfengzhou-hub force-pushed the flink-hive-connector branch 4 times, most recently from 4a7798d to cfcafe3 Compare May 8, 2023 06:18
lindong28
lindong28 reviewed May 8, 2023
View reviewed changes
Copy link
Collaborator

@lindong28 lindong28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Left some comments below.

python/feathub/processors/flink/table_builder/hive_utils.py Outdated Show resolved Hide resolved
python/feathub/feature_tables/sinks/hive_sink.py Outdated Show resolved Hide resolved
python/feathub/feature_tables/sinks/hive_sink.py Outdated Show resolved Hide resolved
python/feathub/processors/flink/table_builder/hive_utils.py Outdated Show resolved Hide resolved
python/feathub/processors/flink/table_builder/hive_utils.py Outdated Show resolved Hide resolved
@yunfengzhou-hub yunfengzhou-hub force-pushed the flink-hive-connector branch 3 times, most recently from e7b30cb to 49ab818 Compare May 9, 2023 03:14
lindong28
lindong28 reviewed May 9, 2023
View reviewed changes
docs/content/connectors/hive.md Outdated Show resolved Hide resolved
python/feathub/common/utils.py Outdated Show resolved Hide resolved
@lindong28
Copy link
Collaborator

Thanks for the update. LGTM.

@lindong28 lindong28 merged commit 06a7a8b into alibaba:master May 10, 2023
@Sxnan Sxnan mentioned this pull request May 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindong28 lindong28 lindong28 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yunfengzhou-hub @lindong28