Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): @types/node pollution #3944

Merged
merged 2 commits into from
Oct 7, 2023

Conversation

Faithfinder
Copy link
Contributor

@Faithfinder Faithfinder commented Aug 24, 2023

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

@formily/core package was bringing in and polluting the global environment with @types/node. This fixes it, you'll notice no more /// <reference types="node" /> at the top of packages/core/esm/types.d.ts after build.

image

Upgrade to rollup plugin, because the project refused to build under the old version for me.

Fixes #3985

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (8861ef5) 99.55% compared to head (02f0164) 99.55%.

Additional details and impacted files
@@              Coverage Diff              @@
##           formily_next    #3944   +/-   ##
=============================================
  Coverage         99.55%   99.55%           
=============================================
  Files               152      152           
  Lines              6709     6709           
  Branches           1876     1876           
=============================================
  Hits               6679     6679           
- Misses               29       30    +1     
+ Partials              1        0    -1     
Files Coverage Δ
packages/core/src/types.ts 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Faithfinder
Copy link
Contributor Author

Not sure what's up with the Compressed Size workflow. Seems like the error is entirely unrelated to changes?

@Faithfinder
Copy link
Contributor Author

Ok, no idea what's up. Help, please.

@janryWang janryWang merged commit bf0ab1c into alibaba:formily_next Oct 7, 2023
8 of 9 checks passed
@Faithfinder Faithfinder deleted the node-pollution branch October 14, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] @formily/core pollutes global with @types/node
2 participants