Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support embeddings API for Qwen in the ai-proxy plugin #1079

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

CH3CHO
Copy link
Collaborator

@CH3CHO CH3CHO commented Jul 2, 2024

Ⅰ. Describe what this PR did

Support embeddings API for Qwen in the ai-proxy plugin.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the README accordingly.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.92%. Comparing base (e389313) to head (79d90fa).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1079      +/-   ##
==========================================
+ Coverage   35.89%   35.92%   +0.02%     
==========================================
  Files          69       69              
  Lines       11549    11549              
==========================================
+ Hits         4146     4149       +3     
+ Misses       7087     7085       -2     
+ Partials      316      315       -1     

see 1 file with indirect coverage changes

@CH3CHO
Copy link
Collaborator Author

CH3CHO commented Jul 5, 2024

Please update the README accordingly.

Done

@CH3CHO CH3CHO requested a review from johnlanni July 5, 2024 03:58
Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit 5a2c683 into alibaba:main Jul 8, 2024
6 checks passed
@CH3CHO CH3CHO deleted the feat/ai-proxy-embeddings branch July 8, 2024 13:23
2456868764 pushed a commit to 2456868764/higress that referenced this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants