doc: add basic_auth plugin english readme #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
CH3CHO
requested changes
Feb 28, 2023
|
@CH3CHO I have make some changes, thanks for correcting me. |
CH3CHO
requested changes
Mar 1, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #221 +/- ##
==========================================
+ Coverage 44.20% 44.58% +0.37%
==========================================
Files 32 32
Lines 5275 5275
==========================================
+ Hits 2332 2352 +20
+ Misses 2774 2754 -20
Partials 169 169 |
johnlanni
approved these changes
Mar 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
doc: add english readme of basic auth
Ⅱ. Does this pull request fix one issue?
fixes #74
Ⅲ. Why don't you add test cases (unit test/integration test)?
this is a doc change, no need to add ut or it
Ⅳ. Describe how to verify it
change plugins/wasm-cpp/extensions/key_rate_limit/README_EN.md and plugins/wasm-cpp/extensions/key_rate_limit/README.md
Ⅴ. Special notes for reviews