Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for hgctl gateway-config to retrieve higress gateway config #274

Merged
merged 2 commits into from
Apr 7, 2023

Conversation

Xunzhuo
Copy link
Collaborator

@Xunzhuo Xunzhuo commented Apr 4, 2023

Ⅰ. Describe what this PR did

feat: add support for hgctl gateway-config to debug higress gateway xds config

  1. support retrieve all configDump from specific higress gateway pod
  2. support retrieve bootstrap config from specific higress gateway pod
  3. support retrieve cluster config from specific higress gateway pod
  4. support retrieve endpoint config from specific higress gateway pod
  5. support retrieve listener config from specific higress gateway pod
  6. support retrieve route config from specific higress gateway pod

xref: #229

image

image

examples:
image

@Xunzhuo Xunzhuo force-pushed the feat-hgctl-config branch 3 times, most recently from de432a8 to a883802 Compare April 6, 2023 08:41
@Xunzhuo Xunzhuo marked this pull request as ready for review April 6, 2023 08:42
@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2023

Codecov Report

Merging #274 (8e00bc4) into main (affa120) will decrease coverage by 2.69%.
The diff coverage is 15.68%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #274      +/-   ##
==========================================
- Coverage   44.99%   42.30%   -2.69%     
==========================================
  Files          34       44      +10     
  Lines        5316     5779     +463     
==========================================
+ Hits         2392     2445      +53     
- Misses       2759     3163     +404     
- Partials      165      171       +6     
Impacted Files Coverage Δ
pkg/cmd/hgctl/configBootstrap.go 0.00% <0.00%> (ø)
pkg/cmd/hgctl/configCluster.go 0.00% <0.00%> (ø)
pkg/cmd/hgctl/configCmd.go 0.00% <0.00%> (ø)
pkg/cmd/hgctl/configEndpoint.go 0.00% <0.00%> (ø)
pkg/cmd/hgctl/configListener.go 0.00% <0.00%> (ø)
pkg/cmd/hgctl/configRoute.go 0.00% <0.00%> (ø)
pkg/cmd/hgctl/root.go 0.00% <0.00%> (ø)
pkg/cmd/hgctl/configRetriever.go 23.75% <23.75%> (ø)
pkg/cmd/hgctl/utils.go 85.00% <85.00%> (ø)

... and 1 file with indirect coverage changes

Signed-off-by: bitliu <bitliu@tencent.com>
@Xunzhuo Xunzhuo changed the title feat: add support for hgctl config to debug gateway xds config feat: add support for hgctl gateway-config to retrieve higress gateway config Apr 6, 2023
@Xunzhuo Xunzhuo changed the title feat: add support for hgctl gateway-config to retrieve higress gateway config feat: add support for hgctl gateway-config to retrieve higress gateway config Apr 6, 2023
@johnlanni
Copy link
Collaborator

cc @SpecialYang @gengleilei

Signed-off-by: bitliu <bitliu@tencent.com>
Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit 0acb04f into alibaba:main Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants