-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add istio patch to fix xds push #52
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
==========================================
- Coverage 29.63% 24.80% -4.83%
==========================================
Files 27 24 -3
Lines 4330 4076 -254
==========================================
- Hits 1283 1011 -272
- Misses 2986 3008 +22
+ Partials 61 57 -4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't understand why use the mcp generator directly. Since the resources were sent to mcp store, why not use the xds generator?
Although these two |
What's protocol between envoy and istio? xds or mcp-over-xds? |
I understand your doubts, in fact, istio will not call pushMcpXds here, only higress will, here is higress reuse the logic related to xds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should reconsider this way in the future. It's better to build our xds server.
Ⅰ. Describe what this PR did
The previous hack implementation caused LDS to be pushed empty
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews