Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add global option for upstream #798

Merged
merged 2 commits into from Jan 26, 2024

Conversation

sjcsjc123
Copy link
Collaborator

Ⅰ. Describe what this PR did

add global option for upstream

Ⅱ. Does this pull request fix one issue?

fixes #785

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

ci pass

Ⅴ. Special notes for reviews

Signed-off-by: sjcsjc123 <1401189096@qq.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2024

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (90f89cf) 38.14% compared to head (aef6441) 38.07%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #798      +/-   ##
==========================================
- Coverage   38.14%   38.07%   -0.08%     
==========================================
  Files          61       61              
  Lines       10342    10391      +49     
==========================================
+ Hits         3945     3956      +11     
- Misses       6098     6136      +38     
  Partials      299      299              
Files Coverage Δ
pkg/ingress/kube/configmap/config.go 78.57% <100.00%> (+1.64%) ⬆️
pkg/ingress/kube/configmap/global.go 30.33% <22.44%> (-1.34%) ⬇️

Signed-off-by: sjcsjc123 <1401189096@qq.com>
Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit acd80d2 into alibaba:main Jan 26, 2024
11 checks passed
@sjcsjc123 sjcsjc123 deleted the global-option-upstream branch February 8, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global configuration supports upstream idle timeout
3 participants