Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use new goproxy in makefile #805

Merged
merged 1 commit into from
Jan 29, 2024
Merged

feat: Use new goproxy in makefile #805

merged 1 commit into from
Jan 29, 2024

Conversation

llahu
Copy link
Contributor

@llahu llahu commented Jan 25, 2024

Ⅰ. Describe what this PR did

Use the new GOPROXY to ensure code compilation succeeds.

Ⅱ. Does this pull request fix one issue?

fixes #804

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@CLAassistant
Copy link

CLAassistant commented Jan 25, 2024

CLA assistant check
All committers have signed the CLA.

@llahu llahu changed the title feat: Use new goproxy in makefile #804 feat: Use new goproxy in makefile Jan 25, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (acd80d2) 38.07% compared to head (94c293b) 38.07%.
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #805   +/-   ##
=======================================
  Coverage   38.07%   38.07%           
=======================================
  Files          61       61           
  Lines       10391    10391           
=======================================
  Hits         3956     3956           
  Misses       6136     6136           
  Partials      299      299           

Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit e67ed48 into alibaba:main Jan 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants