feature: support third-party-jwt for istio access authentication #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xcbeyond
requested review from
johnlanni,
SpecialYang,
Lynskylate and
gengleilei
as code owners
|
|
|
higress/helm/istiod/values.yaml Line 419 in 1e448da @xcbeyond 这里也需要改一下 |
@johnlanni 已修改 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
=======================================
Coverage 24.80% 24.80%
=======================================
Files 24 24
Lines 4076 4076
=======================================
Hits 1011 1011
Misses 3008 3008
Partials 57 57 |
johnlanni
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
support third-party-jwt for istio access authentication
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
本次修改主要涉及 helm安装时，相关配置的修改。通过本地环境直接helm安装（helm install higress -n higress-system higress）验证。
Ⅴ. Special notes for reviews