Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/circle deps #108

Merged
merged 2 commits into from
Oct 24, 2019
Merged

fix/circle deps #108

merged 2 commits into from
Oct 24, 2019

Conversation

brickspert
Copy link
Collaborator

No description provided.

@vercel
Copy link

vercel bot commented Oct 24, 2019 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/umijs/hooks/chn4pfj2o
🌍 Preview: https://hooks-git-fix-circledeps.umijs.now.sh

awmleer
awmleer approved these changes Oct 24, 2019
View reviewed changes
Copy link
Collaborator

@awmleer awmleer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brickspert brickspert merged commit 0c1e942 into master Oct 24, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/circle_deps branch October 24, 2019 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttys026 ttys026 ttys026 approved these changes

@awmleer awmleer awmleer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brickspert @awmleer @ttys026