Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add useCookieState test case #2112

Merged
merged 8 commits into from
Mar 21, 2023

Conversation

KangXinzhi
Copy link
Contributor

@KangXinzhi KangXinzhi commented Mar 11, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English add test useCookieState case and fix documentation
🇨🇳 Chinese 增加useCookieState的一些测试用例,修复文档中默认值的描述

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@liuyib liuyib self-requested a review March 11, 2023 11:48
liuyib
liuyib previously approved these changes Mar 12, 2023
@liuyib
Copy link
Collaborator

liuyib commented Mar 12, 2023

LGTM, thx for your excellent work

@liuyib
Copy link
Collaborator

liuyib commented Mar 12, 2023

@crazylxr ready to merge

@liuyib liuyib changed the title add useCookieState test case and fix documentation test: add useCookieState test case and fix documentation Mar 12, 2023
@liuyib liuyib dismissed their stale review March 15, 2023 12:58

默认值是否持久化,有待商榷,之前的改的有可能 revert

@KangXinzhi KangXinzhi changed the title test: add useCookieState test case and fix documentation Revert "test: add useCookieState test case and fix documentation" Mar 20, 2023
@KangXinzhi KangXinzhi changed the title Revert "test: add useCookieState test case and fix documentation" test: add useCookieState test case Mar 20, 2023
@crazylxr crazylxr merged commit 24245bd into alibaba:master Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants