Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix ipv6 addr calculate error #118

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

hhyasdf
Copy link
Collaborator

@hhyasdf hhyasdf commented Nov 17, 2021

Pull Request Description

Describe what this PR does / why we need it

Fix ipv6 address calculating problems, two functions will fail if use ipv6 subnet.

Does this pull request fix one issue?

NONE.

Describe how you did it

Describe how to verify it

Special notes for reviews

@codecov-commenter
Copy link

Codecov Report

Merging #118 (28bcbce) into main (79905a7) will decrease coverage by 0.38%.
The diff coverage is 58.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
- Coverage   19.76%   19.38%   -0.39%     
==========================================
  Files          31       31              
  Lines        2519     2512       -7     
==========================================
- Hits          498      487      -11     
- Misses       1964     1968       +4     
  Partials       57       57              
Flag Coverage Δ
unittests 19.38% <58.33%> (-0.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/ipam/pod.go 0.00% <0.00%> (ø)
pkg/daemon/utils/ip_range.go 78.94% <100.00%> (-1.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79905a7...28bcbce. Read the comment docs.

@hhyasdf hhyasdf force-pushed the bugfix/ipv6-addr-calculate-error branch from 28bcbce to cb79e87 Compare November 17, 2021 08:59
Copy link
Collaborator

@mars1024 mars1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hhyasdf hhyasdf merged commit f6be730 into alibaba:main Nov 17, 2021
hhyasdf added a commit to hhyasdf/hybridnet that referenced this pull request Nov 30, 2021
…e-error

bugfix: fix ipv6 addr calculate error
@hhyasdf hhyasdf deleted the bugfix/ipv6-addr-calculate-error branch April 18, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants