Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix daemon controller runtime error #138

Merged

Conversation

hhyasdf
Copy link
Collaborator

@hhyasdf hhyasdf commented Jan 20, 2022

Pull Request Description

Describe what this PR does / why we need it

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

pkg/daemon/controller/utils.go Outdated Show resolved Hide resolved
cmd/daemon/daemon.go Outdated Show resolved Hide resolved
@hhyasdf hhyasdf force-pushed the bugfix/fix-daemon-controller-runtime-error branch 5 times, most recently from 78be683 to b70d4e4 Compare January 20, 2022 04:39
@hhyasdf hhyasdf force-pushed the bugfix/fix-daemon-controller-runtime-error branch from b70d4e4 to f2995d8 Compare January 20, 2022 04:45
Copy link
Collaborator

@mars1024 mars1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mars1024 mars1024 merged commit b7df82e into alibaba:ctrl-dev Jan 20, 2022
@hhyasdf hhyasdf linked an issue Jan 27, 2022 that may be closed by this pull request
@hhyasdf hhyasdf deleted the bugfix/fix-daemon-controller-runtime-error branch April 18, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use controller-runtime instead of code-generator
2 participants