Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix release docker push #21

Merged
merged 2 commits into from
Jun 24, 2021

Conversation

hhyasdf
Copy link
Collaborator

@hhyasdf hhyasdf commented Jun 24, 2021

Pull Request Description

Describe what this PR does / why we need it

Fix "docker push" part of release github action.

Does this pull request fix one issue?

NONE

Describe how you did it

Use ramanetworking/rama and ramanetworking/rama-arm64 to save docker images.

Describe how to verify it

Draft a release.

Special notes for reviews

@codecov-commenter
Copy link

Codecov Report

Merging #21 (a6187ad) into main (ea59d4f) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
- Coverage   13.21%   13.16%   -0.05%     
==========================================
  Files          22       23       +1     
  Lines        1907     1937      +30     
==========================================
+ Hits          252      255       +3     
- Misses       1606     1633      +27     
  Partials       49       49              
Flag Coverage Δ
unittests 13.16% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/ipam/pod.go 0.00% <0.00%> (ø)
pkg/utils/bool.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea59d4f...a6187ad. Read the comment docs.

Copy link
Collaborator

@mars1024 mars1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
thanks!

@mars1024 mars1024 merged commit ab6a3dd into alibaba:main Jun 24, 2021
@hhyasdf hhyasdf deleted the fix-release-docker-push branch April 18, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants