Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: daemon cni message error #23

Merged
merged 8 commits into from
Jul 1, 2021

Conversation

hhyasdf
Copy link
Collaborator

@hhyasdf hhyasdf commented Jun 30, 2021

Pull Request Description

Describe what this PR does / why we need it

  1. Fix arp resolve error while pod creating, probably cause a slow pod creation
  2. Remove pod deleting error log while eth0 not found
  3. Fix typo
  4. Fix veth clean error due to cni excute timeout

Does this pull request fix one issue?

NONE

Describe how you did it

  1. Change arp library

Describe how to verify it

It seems a recurrent problem if a node has over 250 pods.

Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2021

Codecov Report

Merging #23 (447fc00) into main (160c7ad) will increase coverage by 2.61%.
The diff coverage is 48.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   13.15%   15.77%   +2.61%     
==========================================
  Files          23       26       +3     
  Lines        1938     2105     +167     
==========================================
+ Hits          255      332      +77     
- Misses       1634     1724      +90     
  Partials       49       49              
Flag Coverage Δ
unittests 15.77% <48.42%> (+2.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/daemon/arp/arp.go 0.00% <0.00%> (ø)
pkg/daemon/arp/client.go 0.00% <0.00%> (ø)
pkg/daemon/arp/packet.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 160c7ad...447fc00. Read the comment docs.

pkg/daemon/server/container.go Outdated Show resolved Hide resolved
@hhyasdf hhyasdf force-pushed the bugfix/daemon-cni-message-error branch from 3066e3f to 447fc00 Compare July 1, 2021 03:24
Copy link
Collaborator

@mars1024 mars1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
Thanks!

@mars1024 mars1024 merged commit 524d8a6 into alibaba:main Jul 1, 2021
@hhyasdf hhyasdf deleted the bugfix/daemon-cni-message-error branch April 18, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants