feat: ice-scripts add config override power #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noyobo
reviewed
Jan 24, 2018
| output: Object.assign({ | ||
| path: paths.appBuild, | ||
| filename: '[name].js', | ||
| publicPath: '/dist/', | ||
| }), | ||
| publicPath: buildConfig.publicPath || '/dist/', |
There was a problem hiding this comment.
publicPath 收敛到 output 里就可以了
There was a problem hiding this comment.
如果覆盖了 publicPath 在 dev 模式下就运行不起来了, 只有在发布的时候才需要
|
done |
noyobo
reviewed
Jan 25, 2018
| regenerator: true, | ||
| moduleName: 'babel-runtime', | ||
| }], | ||
| [babelPluginIce, { libraryName: '@ali/ice' }], |
There was a problem hiding this comment.
babelPluginIce 这个插件看下是否可以通用, 同时 @ali 这些可以删除掉了.
noyobo
reviewed
Jan 25, 2018
| publicPath: '/dist/', | ||
| }), | ||
| publicPath: paths.servedPath, | ||
| }, buildConfig.output || {}), |
There was a problem hiding this comment.
output 的优先级是最高的, 环境变量暂不提供, 容易混淆.
noyobo
approved these changes
Jan 26, 2018
8 tasks
chenbin92
pushed a commit
that referenced
this pull request
May 8, 2020
fix: remove export name before add
chenbin92
pushed a commit
that referenced
this pull request
May 9, 2020
fix: remove export name before add
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
增加 buildConfig 中定义字段覆盖编译配置的能力
目前支持的:
其他特性修改:
支持 环境变量 PUBLIC_URL, 用来指定 output.publicPath, 逻辑同 create-react-app
add babel-plugin-transfrom-runtime to support regenerator-runtime(MIT)
我会在站点上补充一篇工程自定义的文档