Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service is not found when groupName is blank #3779

Closed
horizonzy opened this issue Sep 8, 2020 · 4 comments
Closed

service is not found when groupName is blank #3779

horizonzy opened this issue Sep 8, 2020 · 4 comments
Labels
kind/bug Category issues or prs related to bug. kind/discussion Category issues related to discussion
Milestone
1.4.2

Comments

@horizonzy
Copy link
Collaborator

Describe the bug
service is not found when groupName is blank. if groupName is blank, when request /v1/ns/catalog/service. if DistroFilter.doFilter,it will set groupName as 'DEFAULT_GROUP', but real serviceName's groupName is blank,such as '@@service'

image
image
@horizonzy
Copy link
Collaborator Author

the logic should be same as sdk.serviceName should set as groupName@@serviceName,instead of serviceName=serviceName,groupName=groupName.

@KomachiSion KomachiSion added kind/bug Category issues or prs related to bug. kind/discussion Category issues related to discussion labels Sep 8, 2020
@KomachiSion
Copy link
Collaborator

We need to discuss a solution to resolve it.

@KomachiSion KomachiSion added this to the 1.4.2 milestone Mar 4, 2021
@KomachiSion
Copy link
Collaborator

Fixed by check registered groupName, the groupNamd can't be empty string

@KomachiSion
Copy link
Collaborator

#5196

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Category issues or prs related to bug. kind/discussion Category issues related to discussion
Projects
None yet
Milestone
1.4.2
Development

No branches or pull requests
2 participants
@horizonzy @KomachiSion