Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Replace http client in HttpHealthCheckProcessor #4225

Closed
Maijh97 opened this issue Nov 13, 2020 · 0 comments · Fixed by #4244
Closed

[Refactor] Replace http client in HttpHealthCheckProcessor #4225

Maijh97 opened this issue Nov 13, 2020 · 0 comments · Fixed by #4244
Assignees
@Maijh97
Labels
area/Naming kind/refactor

Comments

@Maijh97
Copy link
Collaborator

Maijh97 commented Nov 13, 2020

Is your feature request related to a problem? Please describe.

The http client used by HttpHealthCheckProcessor is from the ning manufacturer and needs to be replaced with a unified http client.

Describe the solution you'd like

replace the http client used by HttpHealthCheckProcessor with NacosAsyncRestTemplate.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.
@Maijh97 Maijh97 self-assigned this Nov 13, 2020
@Maijh97 Maijh97 mentioned this issue Nov 17, 2020
Merged
5 tasks
KomachiSion pushed a commit that referenced this issue Nov 19, 2020
@Maijh97
[ISSUE #4225] Replace http client in HttpHealthCheckProcessor (#4244)
6f4dbf0 
* for #42255， Replace http client in HttpHealthCheckProcessor.

* Restore the old version number.

* Removes temporary attributes from a method.

* fix Code style.

* Use the EnvUtil.getProperty() method to get the HTTP parameter, leaving it customizable.

* Fix error symbol.

* Remove excess package import.

* Rollback the code about the custom HTTP parameter.

* fix Code style.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Maijh97 Maijh97

Labels
area/Naming kind/refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #4225] Replace http client in HttpHealthCheckProcessor
2 participants
@chuntaojun @Maijh97